Skip to content

Add client implementation for Numbers API, support 7.0 #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 14, 2020
Merged

Add client implementation for Numbers API, support 7.0 #111

merged 9 commits into from
Jan 14, 2020

Conversation

paolobueno
Copy link
Contributor

@paolobueno paolobueno commented Jan 9, 2020 •
edited
Loading

Notes

#108 should be merged first, this PR currently includes commits from it.

Motivation

Add resources related to the Numbers API.

Changes

  • Add Numbers API-related objects
  • Add Numbers API-related resources
  • Add related integration tests
  • Broaden support back to 7.0

@paolobueno paolobueno marked this pull request as ready for review January 10, 2020 08:52
@paolobueno paolobueno force-pushed the numbers branch 2 times, most recently from 96313a6 to b3573f0 Compare January 10, 2020 08:55
felipecoppola
felipecoppola suggested changes Jan 10, 2020
View reviewed changes
This was referenced Jan 13, 2020
Closed
Closed
@paolobueno paolobueno changed the title Add client implementation for Numbers API Add client implementation for Numbers API, support 7.1 Jan 13, 2020
@paolobueno
Copy link
Contributor Author

@felipecoppola Addressed comments and added support back to 7.1 due to an internal request.

Can you give this one a final look? Thanks!

@paolobueno paolobueno force-pushed the numbers branch 2 times, most recently from 41fd0b9 to 772954f Compare January 13, 2020 15:34
@paolobueno paolobueno changed the title Add client implementation for Numbers API, support 7.1 Add client implementation for Numbers API, support 7.0 Jan 13, 2020
@paolobueno paolobueno force-pushed the numbers branch 4 times, most recently from d608410 to 11f0edf Compare January 13, 2020 16:00
@marcelcorso marcelcorso merged commit 0190e80 into messagebird:master Jan 14, 2020
@paolobueno paolobueno deleted the numbers branch January 14, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipecoppola felipecoppola felipecoppola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paolobueno @felipecoppola @marcelcorso